On Mon, 2 Nov 2026 16:25:10 GMT, Markus KARG <[email protected]> wrote:

>> This Pull Request provides an implementation for 
>> [JDK-8389573](https://bugs.openjdk.org/browse/JDK-8389573): 
>> 'InputStreamReader.readAllAsString() should override the generic Reader 
>> default implementation to avoid unnecessary buffer copies'.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Markus KARG has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 16 additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into StreamDecover-readAllAsString
>  - Proof that subclass is not optimized as requested by Jaikiran
>  - Made implRead private as requested by Jaikiran
>  - external decoder -> explicitly provided decoder
>  - internal decoder -> decoder belongs to the Charset instance
>  - Fixed typo readAllString
>  - Protected backwards-compatible behavior of existing subclasses as proposed 
> by Jaikiran Pai
>  - Removed (fast/slow path) comments
>  - Removed readCalled=true from read() and implRead()
>  - Changed according to requests of Alan Bateman and Jaikiran Pai
>  - ... and 6 more: https://git.openjdk.org/jdk/compare/051e9dc7...fc2364f7

Hello Markus,

> 'll follow up on the JDK-8396587 discussion in the coming days and decide how 
> we proceed with this PR. If that takes longer, then I'll see if the test can 
> be temporarily adjusted to make an expection for this overridden method from 
> being considered as problematic.

https://github.com/openjdk/jdk/pull/33865 has just been integrated. Can you 
merge this PR against the latest master branch once more? With that, I expect 
all tests to now pass and that should allow this PR to be integrated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32264#issuecomment-6910361737

Reply via email to