On Tue, 17 Nov 2026 05:56:39 GMT, Jaikiran Pai <[email protected]> wrote:
>> Ashay Rane has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8395991-windows-arm64-jit-pac-ret >> - Make IO.java less brittle by permitting HotSpot warnings >> >> Also update DataDumpDcmdTest.java and LoadAgentDcmdTest.java to use >> `OutputAnalyzer.stderrShouldBeEmptyIgnoreVMWarnings()`. >> - Merge branch 'master' into JDK-8395991-windows-arm64-jit-pac-ret >> - Enable branch protection in CI on just Windows/ARM64 >> >> We deliberately do not enable it on Linux/AArch64 so that depending on >> whether a failure happens on both Windows/ARM64 and Linux/AArch64 (and >> assuming that the failure is unrelated to the OS), we have a better >> chance of knowing whether the failure is related to branch protection. >> - Merge branch 'master' into JDK-8395991-windows-arm64-jit-pac-ret >> - Merge branch 'master' into JDK-8395991-windows-arm64-jit-pac-ret >> - Enable branch protection checks in CI build >> >> The intent behind this change is to make CI catch subtle bugs that >> corrupt return addresses. Whether the protection is actually enforced >> depends on whether the GitHub runner uses an AArch64 processor that >> supports pointer authentication. >> - Merge branch 'master' into JDK-8395991-windows-arm64-jit-pac-ret >> - Documentation updates >> >> - Include section numbers from ARM ISA document >> - Mark branch protection on Windows/ARM64 as supported >> - Enable pointer authentication for JIT code on Windows/ARM64 >> >> This patch enables PAC and AUT instructions for pointer signing and >> authentication in JIT code on Windows/ARM64 when "UseBranchProtection" >> flag is set and when the processor supports the feature. >> >> Specifically, JVM detects hardware support by reading ID_AA64ISAR1_EL1 >> and ID_AA64ISAR2_EL1 registers via CP4031 and CP4032 keys in the Windows >> registry. Then, if the "UseBranchProtection" flag is set, then HotSpot >> emits the signing and authenticating instructions. Windows uses >> AArch64's "B" key, so this patch selects between "paciaz" and "pacibz" >> instructions (and similarly, between "autiaz" and "autibz" instructions) >> depending on whether HotSpot is being compiled for Linux versus Windows. >> Both the MacroAssembler and the Windows' P... > > test/jdk/java/lang/IO/IO.java line 155: > >> 153: OutputAnalyzer output = ProcessTools.executeProcess(pb); >> 154: assertEquals(0, output.getExitValue()); >> 155: output.stderrShouldBeEmptyIgnoreVMWarnings(); > > Hello Ashay, this change to the test is reasonable. I think we should do it > independent of this change. Can you file a separate enhancement issue just > for this and fix it as part of it? Just to be clear this is only necessary because you are forcing `UseBranchProtection` on for the GHA tests - right? The normal expectation is that such a flag is only set when the person launching the VM knows the hardware supports it - hence the warning when you ask for it but the machine doesn't have it. Changing the test as part of this PR seems reasonable to me. > In the process, I discovered a couple of tests (DataDumpDcmdTest.java and > LoadAgentDcmdTest.java) that can be improved to use OutputAnalyzer's > stderrShouldBeEmptyIgnoreVMWarnings(). Those tests don't run in the GHA tier1 testing though do they? We are cautious with accepting warnings in more sophisticated tests because it could hide actual test configuration issues. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33595#discussion_r4596102127
