On Tue, 17 Nov 2026 11:49:55 GMT, Markus KARG <[email protected]> wrote:

>> This Pull Request provides an implementation for 
>> [JDK-8389573](https://bugs.openjdk.org/browse/JDK-8389573): 
>> 'InputStreamReader.readAllAsString() should override the generic Reader 
>> default implementation to avoid unnecessary buffer copies'.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Markus KARG has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 17 additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 
> StreamDecover-readAllAsString
>  - Merge branch 'master' into StreamDecover-readAllAsString
>  - Proof that subclass is not optimized as requested by Jaikiran
>  - Made implRead private as requested by Jaikiran
>  - external decoder -> explicitly provided decoder
>  - internal decoder -> decoder belongs to the Charset instance
>  - Fixed typo readAllString
>  - Protected backwards-compatible behavior of existing subclasses as proposed 
> by Jaikiran Pai
>  - Removed (fast/slow path) comments
>  - Removed readCalled=true from read() and implRead()
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/b1e5a7c8...833a91c0

Marked as reviewed by jpai (Reviewer).

The latest state of this PR in `833a91c0` looks good to me. I have run tier1, 
tier2 and tier3 in our CI and there aren't any related failures.

-------------

PR Review: https://git.openjdk.org/jdk/pull/32264#pullrequestreview-5937909330
PR Comment: https://git.openjdk.org/jdk/pull/32264#issuecomment-6947275041

Reply via email to