On Thu, 19 Nov 2026 15:07:48 GMT, Aggelos Biboudis <[email protected]> 
wrote:

>> There's others too...
>
> It comes verbatim from JDK-8289196: Pattern domination not working properly 
> for record patterns, committed on 7 July 2022 in 
> [8dd94a2c14f](https://github.com/openjdk/jdk/commit/8dd94a2c14f7456b3eaf3e02f38d9e114eb8acc3),
>  before the first primitive patterns preview. JDK-8303374, the first 
> primitive patterns preview, had already removed the XOR check from 
> Check.patternDominated so it didn't propagate.

Yep -- I did a scan and couldn't find any other boolean xor except for the ones 
that we are resurrecting here. I think we should take the opportunity to clean 
this up and use `!=` like rest of javac

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33919#discussion_r4630690142

Reply via email to