On Thu, 19 Nov 2026 22:56:05 GMT, Justin Lu <[email protected]> wrote:
> Changes to `CompactNumberFormat` do not affect the formatting when general > number formatting is used. The specification needs to better define general > versus compact number formatting to make this behavior clear. This gets rid > of any misconceptions which may cause users to believe something such as > `setGroupingUsed(true)` should imply that general number formatting uses > grouping as well, even if the `decimalPattern` provided does not define > grouping in the pattern. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Looks fine to me. src/java.base/share/classes/java/text/CompactNumberFormat.java line 111: > 109: * DecimalFormat} with the {@code decimalPattern} provided to the {@code > CompactNumberFormat}. Such formatting > 110: * never produces fractional digits, even if the underlying decimal > pattern has been composed to use fractional digits. > 111: * Changes to the {@code CompactNumberFormat}, such as setting {@link > #setGroupingUsed(boolean) setting -> calling? Also a comma after the link is preferred. ------------- PR Review: https://git.openjdk.org/jdk/pull/33985#pullrequestreview-5985478108 PR Review Comment: https://git.openjdk.org/jdk/pull/33985#discussion_r4636824852
