On Fri, 20 Nov 2026 01:32:47 GMT, David Holmes <[email protected]> wrote:

> This seems reasonable for the regular parsed classes, but I also see:
> 
> ```
> ./share/cds/lambdaFormInvokers.cpp:  result->add_to_hierarchy(THREAD);
> ./share/cds/lambdaProxyClassDictionary.cpp:  
> lambda_ik->add_to_hierarchy(THREAD);
> ```
> 
> and wonder if it will also pick up things it should not?

Classes regenerated solely for archival, like here, continue to be counted as 
before. Previously, they were counted after restoration, as part of 
SystemDictionary::load_shared_class_misc(), even if later class-definition 
checks rejected them. Moving the notification to hierarchy insertion removes 
that source of overcounting. Successfully loaded archived classes are still 
counted once, with their shared-class attribution preserved. 

Before: restoration → count → definition checks → add_to_hierarchy()
Now:    restoration → definition checks → add_to_hierarchy() / count

If we want to consider removing class accounting for classes that are used only 
for archival purposes, a precedent can be found in 
[JDK-8387756](https://bugs.openjdk.org/browse/JDK-8387756)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33973#issuecomment-7036632285

Reply via email to