On Sat, 14 Nov 2026 10:31:29 GMT, Andrew Haley <[email protected]> wrote:

>>> Oh, certainly, knowing that a problem exists is great, but if there isn't 
>>> any way to reproduce it locally, I worry that the CI failure could get 
>>> downplayed and ignored.
>> 
>> I see. Well, yes, but that's a different domain. Let's leave the 
>> psychoanalysis of our fellow maintainers out of this review.
>
>> @theRealAph I went ahead and updated the CI build rules to pass 
>> "--enable-branch-protection" during the build and 
>> "-XX:UseBranchProtection=standard" during the tests for both Linux/AArch64 
>> and Windows/ARM64.
> 
> Why on both? If we enable branch protection on only one of these, then we're 
> testing both possibilities with every commit, which is exactly what we need.

@theRealAph  Would you be willing to review this patch please?  If I should 
instead ask someone else, please let me know.  Thanks much!

Tangentially related, short of pinging specific people, is there a process for 
soliciting reviews?  I ask because at-mentioning individual people (often 
times, subsystem maintainers, who are understandably busy) seems too invasive.  
The alternative seems to be to wait until someone (especially a capital-r 
Reviewer) notices, but I've seen months go by.  Is there a middle ground that I 
am forgetting/missing?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33595#issuecomment-7044820626

Reply via email to