Separate thread :) While I'm not expert in choosing colors, but I think it would be great for labels that indicate "action needed from human" to be more noticable and distinctive than the "informational" labels.
For example: awaiting labels, CLA not signed, I consider those to be "action needed": don't merge the PR, someone should review, follow up, etc. type-tests, type-documentation, needs backport to, OS Mac/windows, are "informational" IMO. "needs backport to " are mostly for the bot most of the time, except when there's conflict. Mariatta On Thu, Jul 26, 2018 at 10:07 AM Carol Willing <willi...@gmail.com> wrote: > > > > On Jul 24, 2018, at 9:19 AM, Brett Cannon <br...@python.org> wrote: > > > > As the person who chose the colour scheme, I'll try to explain why I did > it the way I did. :) > > > > If you look at https://github.com/python/cpython/labels you will notice > all related labels that have the same prefix are the same colour unless > there is a reason to make it stand out (e.g. type-security). The colours > also try to use appropriate colours to represent whether the label requires > attention (e.g. the "needs" labels are yellow as essentially that label > represents why that PR has not been merged yet). > > > > Finally, I'm enough of a visual learner that I can look at an issue and > notice by colour when a label is missing. So out of habit I make sure > colours are distinct so I can visually notice when an issue is lacking a > certain issue type. > > > > But I'm not attached to any of this, so if someone wants to come up with > a colour scheme that people can generally agree to I'm fine with changing > the colours (I would prefer to avoid changing the label names, though, as > that potentially will break bots and scripts, plus I hate labels that are > not self-describing as they suck for new people). > > Thanks for the explanation Brett. Just for clarification, I wasn't > suggesting changing label names or basic colors. I just think it is a bit > more visually clean to either use all muted or all bold tones for the > colors. My personal preference would be to use muted colors as they are > good for visual learners as well as less distracting for those of us that > get easily distracted ;-) > _______________________________________________ > core-workflow mailing list -- core-workflow@python.org > To unsubscribe send an email to core-workflow-le...@python.org > https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ > This list is governed by the PSF Code of Conduct: > https://www.python.org/psf/codeofconduct >
_______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-le...@python.org https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
