On Fri, Jun 27, 2008 at 05:44:01PM +0200, Stefan Reinauer wrote:
> * add support for Numonyx (formerly ST) M25PE80
See below.
> * drop erroneous "unknown flash chip" entries. They badly clash with the
> "multiple flash chip support" and are no longer required since it's
> possible to force a flash chip with Peter's last patch.
Thumbs up on this. I thought on doing this in my patch, but I wanted
a flashrom mode that was completely equivalent - ie. it would scan
for known vendors. But I am fine with removing this right now.
> {"Macronix", "MX25L3205", MX_ID, MX_25L3205,
> 4096, 256, TEST_OK_PREW, probe_spi_rdid,
> spi_chip_erase_c7, spi_chip_write, spi_chip_read},
> {"Macronix", "MX29F002", MX_ID, MX_29F002,
> 256, 64 * 1024, TEST_UNTESTED, probe_29f002,
> erase_29f002, write_29f002},
> + {"Numonyx", "M25PE80", ST_ID, 0x8014,
> 1024, 256, TEST_UNTESTED, probe_spi_rdid,
> spi_chip_erase_c7, spi_chip_write, spi_chip_read},
Does this indent just break in the patch but look good in your file?
And, did you intentionally not make a #define for the product id?
//Peter
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
