On Fri, Jun 27, 2008 at 06:25:35PM +0200, Stefan Reinauer wrote:
> > > {"Macronix", "MX29F002", MX_ID, MX_29F002,
> > > 256, 64 * 1024, TEST_UNTESTED, probe_29f002,
> > > erase_29f002, write_29f002},
> > > + {"Numonyx", "M25PE80", ST_ID, 0x8014,
> > > 1024, 256, TEST_UNTESTED, probe_spi_rdid,
> > > spi_chip_erase_c7, spi_chip_write, spi_chip_read},
> >
> > Does this indent just break in the patch but look good in your file?
>
> Thanks for noticing. It's indeed broken. I will fix it in the
> commit if I get an Acked.
>
> > And, did you intentionally not make a #define for the product id?
>
> Yes, that is on purpose. I think it is a bad bad idea to define
> every flash chip in two different places in two different files in
> the tree.
With the indent fix:
Acked-by: Peter Stuge <[EMAIL PROTECTED]>
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
