Peter Stuge wrote:
On Sat, Aug 02, 2008 at 05:04:40PM +0200, Stefan Reinauer wrote:
erased blockwise
..
+int spi_chip_erase(struct flashchip *flash);

Please change the function names to match the functionality.
It erases the chip?

Since it does not do blockwise erase on all chipsets, pretending it did would be bad.


--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
     Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED]  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


Attachment: signature.asc
Description: OpenPGP digital signature

--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to