On Sat, Aug 02, 2008 at 05:04:40PM +0200, Stefan Reinauer wrote:
> Add support for Numonyx M25PE80. This chip requires to be erased
> blockwise, as the c7 method is unreliable, either for ICH7 or for
> this chip.
> 
> Signed-off-by: Stefan Reinauer <[EMAIL PROTECTED]>

Acked-by: Peter Stuge <[EMAIL PROTECTED]>


On Sat, Aug 02, 2008 at 05:12:19PM +0200, Stefan Reinauer wrote:
> >>erased blockwise
> >..
> >>+int spi_chip_erase(struct flashchip *flash);
> >
> >Please change the function names to match the functionality.
> 
> It erases the chip?
> 
> Since it does not do blockwise erase on all chipsets, pretending it
> did would be bad.

Right you are. This is the best solution at the moment!


//Peter

Attachment: pgpzCtUHe6CYn.pgp
Description: PGP signature

--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to