On 09.08.2008 18:56, ron minnich wrote:
> Comment in patch. Tested on dbe62. Note comment w.r.t. regressions,
> which we need to fix.
>
> [....]
> Index: northbridge/amd/geodelx/raminit.c
> ===================================================================
> --- northbridge/amd/geodelx/raminit.c (revision 726)
> +++ northbridge/amd/geodelx/raminit.c (working copy)
> @@ -66,7 +66,10 @@
> for (i = 0; i < ARRAY_SIZE(msrs); i++) {
> struct msr msr;
> msr = rdmsr(msrs[i]);
> - printk(BIOS_DEBUG, "%s (%lx): %x.%x\n", msrnames[i], msrs[i],
> + /* don't change the %p to a %s unless you fix the problem.
> + * in particular, don't change or submit a patch UNLESS YOU
> TEST IT
> + */
> + printk(BIOS_DEBUG, "%p (%lx): %x.%x\n", msrnames[i], msrs[i],
> msr.hi, msr.lo);
> }
>
> [...]
>
Separate patch for that one, please.
The rest is
Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>
Regards,
Carl-Daniel
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
