On Mon, Sep 1, 2008 at 8:12 AM, Carl-Daniel Hailfinger
<[EMAIL PROTECTED]> wrote:
> Hi,
>
> this patch is not to be applied, but an annotation from my tree.
>
> Index: northbridge/amd/k8/dqs.c
> ===================================================================
> --- northbridge/amd/k8/dqs.c (Revision 853)
> +++ northbridge/amd/k8/dqs.c (Arbeitskopie)
> @@ -2001,6 +2001,7 @@
> static inline void train_ram_on_node(unsigned nodeid, unsigned coreid,
> struct sys_info *sysinfo, unsigned retcall)
> {
> if(coreid) return; // only do it on core0
> +#error This is broken beyond repair. We need to use the generic global
> variable infrastructure, especially if we relocate the global variables
> without telling anybody.
These fixes come in to play once single core is done.
We're going to write this code as always SMP safe, and I want to
remove the CONFIG_*_SMP conditionals. They make no sense for a bios.
ron
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
