Uwe Hermann wrote:
> On Fri, Oct 03, 2008 at 04:31:01AM +0200, Carl-Daniel Hailfinger wrote:
>
>> Thanks to Jason Zhao we got a skeleton CAR code for VIA C7. I have tried
>> to clean it up a bit and find justifications for every difference from
>> x86 and AMD CAR code. I believe this is mostly merge-ready. Although I'd
>> have preferred to do this for v3 first, we can fix v2 boards with this
>> change and then move them to v3.
>> Thanks to Bari Ari for getting the code to me for rewrite/review.
>>
>> CONFIG_CARTEST shall not be enabled (breaks the build).
>>
>> Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>
>> Signed-off-by: Jason Zhao <[EMAIL PROTECTED]>
>>
>
> Very nice, thanks!
>
> Acked-by: Uwe Hermann <[EMAIL PROTECTED]>
>
>
> Can't test here either, but see comments below:
>
>
>
>> Index: LinuxBIOSv2-via_CAR/src/cpu/via/car/cache_as_ram.lds
>> ===================================================================
>> --- LinuxBIOSv2-via_CAR/src/cpu/via/car/cache_as_ram.lds (Revision 0)
>> +++ LinuxBIOSv2-via_CAR/src/cpu/via/car/cache_as_ram.lds (Revision 0)
>> @@ -0,0 +1,11 @@
>> +SECTIONS {
>> + .init . : {
>> + _init = .;
>> + *(.init.text);
>> + *(.init.rodata);
>> + *(.init.rodata.*);
>> + . = ALIGN(16);
>> + _einit = .;
>> + }
>> +
>> +}
>>
>
> This is an exact copy of
> cpu/x86/car/cache_as_ram.lds (no license header)
> and
> cpu/amd/car/cache_as_ram.lds (this one says
> (C) Stefan Reinauer <[EMAIL PROTECTED]> but doesn't mention a license)
>
Feel free to add a GPLv2 header.
That code is so trivial that whoever copied it to the VIA directory
can/should claim copyright on those parts. It has no originative value.
> Can we use only one of the files for all CAR implementations (probably
> requires a small fix in the build system, not sure)?
>
It would require all mainboard Config.lb files to be touched. Not a big
deal I guess.
> Or, at least, all of them should have a proper GPL header.
>
> This shouldn't hold up a commit, but we should definately fix
> it (now or later)
Absolutely. Whoever steps up, I think this qualifies for a self-acked patch.
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED] • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
signature.asc
Description: OpenPGP digital signature
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
