On 03.10.2008 14:18, Uwe Hermann wrote: > On Fri, Oct 03, 2008 at 04:31:01AM +0200, Carl-Daniel Hailfinger wrote: > >> Thanks to Jason Zhao we got a skeleton CAR code for VIA C7. I have tried >> to clean it up a bit and find justifications for every difference from >> x86 and AMD CAR code. I believe this is mostly merge-ready. Although I'd >> have preferred to do this for v3 first, we can fix v2 boards with this >> change and then move them to v3. >> Thanks to Bari Ari for getting the code to me for rewrite/review. >> >> CONFIG_CARTEST shall not be enabled (breaks the build). >> >> Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> >> Signed-off-by: Jason Zhao <[EMAIL PROTECTED]> >> > > Very nice, thanks! > > Acked-by: Uwe Hermann <[EMAIL PROTECTED]> > > > Can't test here either, but see comments below: > [...] >
I addessed the comments as well as I could. Committed in r3634. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
