On Wed, Oct 15, 2008 at 01:11:54PM -0500, Alex Mauer wrote:
> Signed-off-by: Alex Mauer <[EMAIL PROTECTED]>

With the changes below this is:
Acked-by: Uwe Hermann <[EMAIL PROTECTED]>


> Index: src/mainboard/bcom/winnetp680/Config.lb
> ===================================================================
> --- src/mainboard/bcom/winnetp680/Config.lb   (revision 3654)
> +++ src/mainboard/bcom/winnetp680/Config.lb   (working copy)
> @@ -99,16 +99,14 @@
>        register "ide1_80pin_cable" = "0"
>        register "fn_ctrl_lo" = "0x80"
>        register "fn_ctrl_hi" = "0x1d"
> -      device pci a.0 on end                  # Firewire
> -      device pci f.0 on end                  # SATA
> -      device pci f.1 on end                  # IDE
> -      device pci 10.0 on end                 # OHCI
> -      device pci 10.1 on end                 # OHCI
> -      device pci 10.2 on end                 # OHCI
> -      device pci 10.3 on end                 # OHCI
> +      device pci f.0 on end                  # IDE
> +      device pci 10.0 on end                 # UHCI
> +      device pci 10.1 on end                 # UHCI
> +      device pci 10.2 on end                 # UHCI
> +      device pci 10.3 on end                 # UHCI
>        device pci 10.4 on end                 # EHCI
>        device pci 11.0 on                     # Southbridge LPC
> -        chip superio/fintek/f71805f          # Super I/O
> +        chip superio/winbond/w83697hf                # Super I/O
>            device pnp 2e.0 off                        # Floppy
>              io 0x60 = 0x3f0
>              irq 0x70 = 6
> @@ -127,13 +125,17 @@
>              io 0x60 = 0x2f8
>              irq 0x70 = 3
>            end
> +          device pnp e2.6 off end            # Consumer IR

e2 should be 2e, also in the lines below....


> +          device pnp e2.7 off end            # Game port, GPIO 1
> +          device pnp e2.8 off end            # MIDI port, GPIO 5
> +          device pnp e2.9 off end            # GPIO 2-4
> +          device pnp e2.a off end            # ACPI

>            device pnp 2e.b on                 # HWM
>              io 0x60 = 0xec00

Why 0xec00 here? IIRC superiotool said 0x290 (which is the usual value
for a hardware monitor).


>            end
>          end
>        end
>        device pci 11.5 on end                 # AC'97 audio
> -      # device pci 11.6 off end                      # AC'97 Modem
>        device pci 12.0 on end                 # Ethernet
>      end
>    end
> Index: src/mainboard/bcom/winnetp680/irq_tables.c
> ===================================================================
> --- src/mainboard/bcom/winnetp680/irq_tables.c        (revision 3654)
> +++ src/mainboard/bcom/winnetp680/irq_tables.c        (working copy)
> @@ -2,7 +2,7 @@
>   * This file is part of the coreboot project.
>   *
>   * Copyright (C) 2008 VIA Technologies, Inc.
> - * (Written by Aaron Lwe <[EMAIL PROTECTED]> for VIA)
> + * Generated by GetPIR

(C) 2008 Alex Mauer <[EMAIL PROTECTED]>

I'd say, but it doesn't really matter much.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to