Corey Osgood wrote:
2008/10/17 Uwe Hermann <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>

    See patch.


    Drop unneeded enable_mainboard_devices() function, the lines

          register "fn_ctrl_lo" = "0x80"
          register "fn_ctrl_hi" = "0x1d"

    in the Config.lb file should do exactly the same (but please test that)!

    Also, drop some unused variables and (IMHO) unneeded debug messages.


NACK. If the devices aren't enabled/disabled (and in the process hidden/revealed) before PCI bringup, coreboot will get very confused when they disappear and appear out of nowhere.

would it be feasible to have enable_mainboard_devices() read the structure setup by Config.lb so that those values can come from just one place?

-Alex Mauer "hawke"


--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to