On 28.10.2008 18:05, Myles Watson wrote: > On Tue, Oct 28, 2008 at 10:36 AM, Marc Jones <[EMAIL PROTECTED]> wrote: > > >> ron minnich wrote: >> >> >>> On Tue, Oct 28, 2008 at 8:03 AM, Myles Watson <[EMAIL PROTECTED]> wrote: >>> >>> >>>> Here's a list of the #defines that I think we should look at. I would >>>> like >>>> to detect as many as possible, and add the rest to the dts or Kconfig. >>>> >>>> >>> ... >>> >>> ./raminit.c:#if CPU_SOCKET_TYPE == SOCKET_L1 >>> >>>> ./raminit.c:#if CPU_SOCKET_TYPE == SOCKET_AM2 >>>> >>>> >>> yes, these are trivial to detect at runtime. >>> >>> ./raminit.c:#if DIMM_SUPPORT==0x0104 /* DDR2 and REG */ >>> >>> This ought to be determined somehow but not sure how. >>> >>> >> These two are related. The socket type defines the package and by extension >> what type of dimms are supported. It is better to define the socket for the >> platform than trying to detect it since it can't change. >> > > > So it should be in the dts, right? I think the more things we put in one > place the easier later ports will be. >
Yes. The cpu block in the dts is still empty and could use some more info. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
