On Tue, Dec 16, 2008 at 9:26 AM, Pattrick Hueper <[email protected]> wrote:
> On Tue, Dec 16, 2008 at 5:21 PM, Myles Watson <[email protected]> wrote: > > > > > > On Tue, Dec 16, 2008 at 6:14 AM, Pattrick Hueper <[email protected]> > wrote: > >> > >> Hi, > >> > >> On Mon, Dec 15, 2008 at 7:28 PM, Peter Stuge <[email protected]> wrote: > >> > On the other hand, it is of course expected to have descriptive > >> > file names, which makes biosemu.c a good name for a file doing BIOS > >> > emulation in any case. > >> > > >> ... > >> > > >> > It could go into Kconfig but users should not be bothered with it. > >> > Maybe make it changeable for experts only. > >> > > >> > >> here are two more patches, > >> > >> - rename biosemu to YABEL in Kconfig, CONFIG variables and directory > >> - make the virtual memory location and size editable in Kconfig > > > > Ok, thats true... i will remove it... i have played with more than 1MB > virtual memory once, but it isnt really needed... > > > > >> > > I would take out the default setting in Kconfig. If the person has to be > an > > expert to change it, and they're changing it, there shouldn't be a > default. > > > > Hm... taking out the default would mean, that if you select expert you > _have_ to enter a value... since it is not preset? That seems a little > bit too much expertism to expect... providing a sensible default seems > to make sense IMHO. You're right, that also doesn't make sense. I meant make it so that you have to provide a value if you want to change it. So could you introduce a boolean that deafaults to false and depends on expert that is "set the address for yabel", then not have a default for the address. Thanks, Myles
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
