On Tue, Dec 16, 2008 at 10:05 AM, Myles Watson <[email protected]> wrote:
> > > On Tue, Dec 16, 2008 at 10:01 AM, Pattrick Hueper <[email protected]>wrote: > >> On Tue, Dec 16, 2008 at 5:28 PM, Myles Watson <[email protected]> wrote: >> >> >> >> Ok, thats true... i will remove it... i have played with more than 1MB >> >> virtual memory once, but it isnt really needed... >> >> >> ... >> > >> > You're right, that also doesn't make sense. I meant make it so that you >> > have to provide a value if you want to change it. So could you >> introduce a >> > boolean that deafaults to false and depends on expert that is "set the >> > address for yabel", then not have a default for the address. >> > >> > Thanks, >> > Myles >> > >> > >> >> Update patch attached. Removed size setting, changed location setting >> as proposed. > > Looks good, but I don't see the default value. It's just in the comment. > If you add the default value and send the updated patches, we can commit. > Now you think I'm a nut. I am :) You don't need to add the default value, the comment made me think there should be one there. You could change the wording there, or not. This is starting to get too picky for an initial commit. Sorry. Myles
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
