On 22.12.2008 17:01, Myles Watson wrote: > >> -----Original Message----- >> From: Carl-Daniel Hailfinger [mailto:[email protected]] >> Sent: Monday, December 22, 2008 8:52 AM >> To: [email protected] >> Cc: Myles Watson; Coreboot >> Subject: Re: [coreboot] [RFC] Error out on implicit declarations >> >> On 18.12.2008 15:52, Jordan Crouse wrote: >> >>> Myles Watson wrote: >>> >>>> On Thu, Dec 18, 2008 at 3:18 AM, Carl-Daniel Hailfinger < >>>> [email protected]> wrote: >>>> >>>> >>>>> Bao, Zheng found a bug which killed SATA booting on my board. >>>>> >>>>> This happened because we do not error out on implicit function >>>>> declarations. The linker has no way of checking whether the implicitly >>>>> assumed function signature is identical to the real signature, so >>>>> mismatches can occur and these mismatches are practically impossible >>>>> >> to >> >>>>> debug because the code looks completely correct. >>>>> >>>>> Adding -Werror-implicit-function-declaration to our CFLAGS would solve >>>>> this problem nicely, but a lot of files in the tree need to be fixed. >>>>> >> Fix implicit udelay src/southbridge/nvidia/mcp55/mcp55_aza.c >> Fix imlicit mdelay in src/southbridge/nvidia/mcp55/mcp55_nic.c >> >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >> >> abuild tested on all MCP55 targets. >> > Acked-by: Myles Watson <[email protected]> >
Thanks, r3831. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
