Hi, Carl-Daniel, I deleted trailing white spaces in your dbm690t patch. I think the style of pistachio should be match with dbm690t. Do you think?
Zheng Signed-off-by: Zheng Bao <[email protected]> -----Original Message----- From: Carl-Daniel Hailfinger [mailto:[email protected]] Sent: Tuesday, December 23, 2008 10:31 AM To: Bao, Zheng Cc: [email protected] Subject: Re: [coreboot] [RFC] Error out on implicit declarations Hi Zheng, sorry for the delayed response. On 23.12.2008 03:02, Bao, Zheng wrote: > Carl-Daniel, > Can you acked-by these patches for implicit declaration? > The SB600 patch is Acked-by: Carl-Daniel Hailfinger <[email protected]> and committed in revision 3837. I think we can make the DBM690T patch shorter. What do you think? Fix implicit declarations in the AMD DBM690T target by using the right header files. Signed-off-by: Carl-Daniel Hailfinger <[email protected]> Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c =================================================================== --- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c (Revision 3837) +++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/fadt.c (Arbeitskopie) @@ -25,6 +25,8 @@ #include <console/console.h> #include <arch/acpi.h> #include <arch/io.h> +#include <device/device.h> +#include <../southbridge/amd/sb600/sb600.h> /*extern*/ u16 pm_base = 0x800; /* pm_base should be set in sb acpi */ Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c =================================================================== --- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c (Revision 3837) +++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/mainboard.c (Arbeitskopie) @@ -25,6 +25,7 @@ #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> +#include <../southbridge/amd/sb600/sb600.h> #include "chip.h" #define ADT7461_ADDRESS 0x4C @@ -34,6 +35,8 @@ extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32 address); extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, u8 val); +extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, + uint64_t start, uint64_t size); #define ADT7461_read_byte(address) \ do_smbus_read_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address) #define ARA_read_byte(address) \ -- http://www.hailfinger.org/
dbm690t_implicit.patch
Description: dbm690t_implicit.patch
pistachio_implicit.patch
Description: pistachio_implicit.patch
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
