Hi,

I think I understand your patch a little bit better now.

OK good.

The first
pci device is used to obtain the framebuffer size, and the second
device is used to find the ram speed.

Yep. Check this:

http://linux.via.com.tw/support/beginDownload.action?eleid=161&fid=241
(page 70)

Its from VX800 (which Jason already added in his not yet published patch)
Its exactly the same as for K8M890.

The memory speed is in: http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/32559.pdf

Perhaps we should break this into two separate functions - that way
it's clear that each device provides independent information.
(Something like the attached?)

Yes, but please leave it with the warnings as I did. It is difficult to know where is the problem if we blindly supply default without knowing.

Also, does unichrome/openchrome drivers need the framebuffer size?
It seems odd to me that they'd read a scratch register for that, when
they could just as easily read the real register.

Yes it is like that. Perhaps to make it more hw independent?

Rudolf

--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to