On Sun, Feb 8, 2009 at 5:05 PM, Peter Stuge <[email protected]> wrote: > ron minnich wrote: >> I am not sure why we have that test for flashbase anyway. What's it >> matter? Why do we use the old value for the next value? > > The reason it is used like that is that SC520 code runs before all > probes and can set flashbase, which should then be used by the > probes. > > > ron minnich wrote: >> relative to the start of the chip yes. But the chip itself could be >> physically addressed at, e.g., 0x8000000, and all the programming >> would be fine. > > If the chip is at top of 4GB and the base does is not the start of > the chip some if not all commands to the chip will fail. > > >> The only issue I've had with physical chip address was on the >> sc520, where the put a bunch of registers in the middle of the >> flash address space. > > Many flash chips also have registers, and even if they don't at the > very least block erase operations absolutely need the mmap to start > where the flash chip starts. > > Attaching my suggested patch. Myles, could you give it a go please?
It works for me. Acked-by: Myles Watson <[email protected]> Thanks, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot

