On Fri, Apr 17, 2009 at 10:20 AM, ron minnich <[email protected]> wrote: > On Fri, Apr 17, 2009 at 9:16 AM, Myles Watson <[email protected]> wrote: > >> I forgot to include a usage note. I tested it by adding: >> >> sharedinclude "Config2.lb" >> >> to src/northbridge/amd/amdk8/Config.lb >> >> and it looks in >> >> src/config/shared/Config2.lb > > We used to have these kinds of commands that sort of "built in" a > path. E.g. northbridge intel/xyz had an implicit path of > src/northbridge/intel/xyz. > > We took them out at the request of a vendor. So, just checking, is > this really better than > include /config/shared/Config2.lb > ?
Not really. I guess I couldn't tell from Carl-Daniel's request what exactly he wanted. I thought this would be enough to let him make something work. I admit it was quick and dirty. It could be easily changed to take a path instead of a string. > Also, Config2? Is there a better name, since you did a good thing and > let us use any name we want? It was just an example to make it obvious that it wasn't hardcoded to Config.lb :) Thanks for the review, Myles -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
