On 17.04.2009 19:38, Myles Watson wrote: > On Fri, Apr 17, 2009 at 11:15 AM, Stefan Reinauer <[email protected]> > wrote: > >> Myles Watson schrieb: >> >>> On Fri, Apr 17, 2009 at 10:28 AM, ron minnich <[email protected]> wrote: >>> >>> >>>> On Fri, Apr 17, 2009 at 9:25 AM, Myles Watson <[email protected]> wrote: >>>> >>>> >>>> >>>>> Not really. I guess I couldn't tell from Carl-Daniel's request what >>>>> exactly he wanted. I thought this would be enough to let him make >>>>> something work. I admit it was quick and dirty. It could be easily >>>>> changed to take a path instead of a string. >>>>> >>>>> >>>> Since you are up to speed on the config tool, and know how to improve >>>> it :-), I'd like to request a general purpose include command instead >>>> (or see if there is already one in there I forgot about :-) >>>> >>>> >>> I didn't find one when I looked. I think it would be hard to make one >>> that worked in targets/*/*/Config.lb files and src/.../Config.lb >>> files, but I guess no one has asked for that. >>> >>> How general are you thinking? I'm probably willing to do this: >>> >>> include acpi.lb >>> >>> include /acpi.lb >>> >>> Where acpi.lb includes from the current directory and /acpi.lb >>> includes from /src/acpi.lb >>> >>> >> Whats wrong with the "dir" command? >>
If you want to factor out some small chunks, having to create a separate directory for each chunk is horrible. >> Especially since we're working on getting rid of Config.lb in favor of >> Kconfig.. >> > > I think the idea was a little more flexibility. If it is going away > soon it should be fine to let cleanups happen. Hopefully they'll > speed up the conversion to Kconfig when it happens. > > This include is very simple and related to the dir command. > > Implemented with relative and absolute paths. > > Signed-off-by: Myles Watson <[email protected]> > Awesome, thanks! If this works, it is Acked-by: Carl-Daniel Hailfinger <[email protected]> Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
