On 21.04.2009 05:37, Myles Watson wrote: > >> -----Original Message----- >> From: ron minnich [mailto:[email protected]] >> On Mon, Apr 20, 2009 at 7:50 PM, ron minnich <[email protected]> wrote: >> >>> the issue is that include files need an end statement. Long story. My >>> >> fault. >> >> that's not quite it either, sorry, it's been a long day. >> > > I think that this small patch fixes it. It seems that | is special to the > tokenizer and needs to be [|], so "||" => "[|][|]". There are no > occurrences of || that I can find in Config.lb files, which probably means > that this bug has stopped people from using it. I made up a test case, but > nothing real. I'd love for someone to think of a place they'd like to use > || in a Config.lb file and try it out. > > Signed-off-by: Myles Watson <[email protected]> >
I can't verify the correctness of this, but it fixes a real issue. Acked-by: Carl-Daniel Hailfinger <[email protected]> >>> + >>> +## This is needed to work around a parser bug. >>> +if USE_FALLBACK_IMAGE >>> +end >>> + >>> > > This snippet will also disappear from config/nofailovercalculation.lb with > an ack. > Could you tackle config/nofailovercalculation128.lb as well? It has the same workaround. Thanks. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
