Re: [coreboot] [patch] fix intel 82810 onboard VGA and SDRAM functions

[Joseph Smith]

On Mon, 11 May 2009 06:52:26 -0600, Myles Watson <myle...@gmail.com> wrote:
> On Sun, May 10, 2009 at 6:21 AM, Elia Yehuda <z4zi...@gmail.com> wrote:
>> This patch enables the onboard VGA found on 82810 boards and fixes the
>> memory procedures to support different kinds of DIMMs. also, support for
>> 82810e board had been added. The only drawback from this patch is the
>> HAVE_HIGH_TABLES being disabled since it disables (for unknown reason)
>> the onboard VGA.
> It looks like the problem is that the memory you're reserving for VGA
> and the memory reserved for high tables ends up in the same place
> (ending at tomk.)  If you decide which one should go at the end and
> modify the math, it should work.
> 
>> Signed-off-by: Elia Yehuda <z4zi...@gmail.com>
>> Acked-by: Corey Osgood <corey.osg...@gmail.com>
> 
> Since it looks like an easy fix, let's get it right before committing
> it.  It breaks SeaBIOS, and our assumption that HAVE_HIGH_TABLES
> doesn't break anything.
> 
Take a look at how the i945 does this in northbridge.c, It should work
here.

-- 
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org


-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot