On Mon, May 11, 2009 at 3:52 PM, Myles Watson <[email protected]> wrote:
> On Sun, May 10, 2009 at 6:21 AM, Elia Yehuda <[email protected]> wrote: > > This patch enables the onboard VGA found on 82810 boards and fixes the > > memory procedures to support different kinds of DIMMs. also, support for > > 82810e board had been added. The only drawback from this patch is the > > HAVE_HIGH_TABLES being disabled since it disables (for unknown reason) > > the onboard VGA. > It looks like the problem is that the memory you're reserving for VGA > and the memory reserved for high tables ends up in the same place > (ending at tomk.) If you decide which one should go at the end and > modify the math, it should work. i completely agree - there seems to be an overlapped memory region, but i couldn't trace it deep enough to be able to fix it. sorry... im not familiar enough with coreboot code. i suspect you guys will have better luck. > > > > Signed-off-by: Elia Yehuda <[email protected]> > > Acked-by: Corey Osgood <[email protected]> > > Since it looks like an easy fix, let's get it right before committing > it. It breaks SeaBIOS, and our assumption that HAVE_HIGH_TABLES > doesn't break anything. > i'll keep an eye on HAVE_HIGH_TABLES patches and migrate them to my patches and check if it fix the issue. i'll update the ml as for the results. > > Thanks, > Myles > Elia.
-- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
