Luc Verhaegen wrote:
> Implement native VGA Support.

Looks great! Just one question:


> --- src/include/pc80/vga.h    (revision 4298)
> +++ src/include/pc80/vga.h    (working copy)
> @@ -1,228 +1,43 @@
>  /*
> + * Copyright (C)  2007-2009  Luc Verhaegen <[email protected]>
>   *
> - * modified
> - * by Steve M. Gehlbach <[email protected]>
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the Free
> + * Software Foundation; either version 2 of the License, or (at your option)
> + * any later version.
>   *
> - * Originally  from linux/drivers/video/vga16.c by
..

Is all the stuff in vga.h useless? Not used anywhere? Would it make
sense to first rm the file and then add your new file instead, for a
cleaner commit?


//Peter

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to