On Wed, May 27, 2009 at 08:03:56PM +0200, Peter Stuge wrote: > Luc Verhaegen wrote: > > Implement native VGA Support. > > Looks great! Just one question: > > > > --- src/include/pc80/vga.h (revision 4298) > > +++ src/include/pc80/vga.h (working copy) > > @@ -1,228 +1,43 @@ > > /* > > + * Copyright (C) 2007-2009 Luc Verhaegen <[email protected]> > > * > > - * modified > > - * by Steve M. Gehlbach <[email protected]> > > + * This program is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License as published by the > > Free > > + * Software Foundation; either version 2 of the License, or (at your > > option) > > + * any later version. > > * > > - * Originally from linux/drivers/video/vga16.c by > .. > > Is all the stuff in vga.h useless? Not used anywhere? Would it make > sense to first rm the file and then add your new file instead, for a > cleaner commit? > > > //Peter
Mostly useless, yes, only the console code used a very minor part of it. It was a direct copy of the code from the kernel, and no code to back it was actually left in the tree. A cleaner commit would mean a broken state in between, and the resulting vga.h is really rather small and boring. But if a broken in between state is acceptable then sure. If only svn (or whatever - everything has this issue) diff was intelligent enough not to treat "^ *\n" or "^\n" as valid points of comparison, then it would not be an issue here :) I could also first cut down vga.h until only what the console code uses remains and then apply the other one on top. This will mean the best of both i guess. Thanks, Luc Verhaegen. -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
