Hi,

attached patch fixes an oversight in cbfstool related to bootblock handling.
With this patch, cbfstool reacts to a too large bootblock file by stopping with an error code. Before, it did "whatever" (besides printing a warning).


Signed-off-by: Patrick Georgi <[email protected]>
Index: util/cbfstool/util.c
===================================================================
--- util/cbfstool/util.c        (revision 4328)
+++ util/cbfstool/util.c        (working copy)
@@ -222,7 +222,8 @@
        rom->header->align = htonl(align);
        rom->header->offset = htonl(0);
 
-       add_bootblock(rom, bootblockname);
+       if (add_bootblock(rom, bootblockname) == -1)
+               return -1;
 
        /* Write the cbfs master header address at the end of the ROM. */
 
-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to