Originally I defined the struct and access the controller by the member of the struct. But the code couldn't work at first. Then I changed every "a->b" to "a[XX]". Obviously it doesn't make any sense. Now the code has been working so far, but I haven't got passion to change them back. Maybe later I will do it.
Zheng -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Carl-Daniel Hailfinger Sent: Tuesday, June 23, 2009 8:49 AM To: Luc Verhaegen Cc: Coreboot Subject: Re: [coreboot] [PATCH] flashrom: SB600 SPI: Kill unused variable On 23.06.2009 00:09, Luc Verhaegen wrote: > On Mon, Jun 22, 2009 at 04:31:44PM +0200, Carl-Daniel Hailfinger wrote: > >> SB600 SPI: Kill unused variable. >> >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> >> >> > If this builds, then what can be wrong with this :) > > I guess you are keeping this struct because publically available > documentation is perhaps not as clear as it should be? Well, the documentation is pretty readable, but the struct is a handy compressed reference and useful if you want to avoid reading dozens of datasheet pages. > Why not comment > it completely so that no-one else will complain about it in future? Done. > Please also make reset_internal_fifo_pointer and execute_command static > so thatthese symbols, when unused, will turn up in the build as well. > Done. > Apart from that, of course: > Acked-by: Luc Verhaegen <[email protected]> > Thanks, committed in r623. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
