Myles Watson wrote: > >> Maybe since these options are romcc-specific they should be > >> ROMCC_MMX & ROMCC_SSE.
They are only used by romcc, but they are really hardware specific. We could rename them now, but the first time they are used for something other than romcc they would have be to changed back. I prefer keeping them. > >> I just noticed that on my K8 boards SSE=0, which is confusing. > > > > Why not set SSE to 1 then? They have it. > > Because it doesn't do anything and I think that having extra values > goes against KISS. From the board port perspective it shouldn't matter if they do anything. They should be set when appropriate. I don't think they should be set by boards. There can certainly be exceptions, but for K8 I say just remove them from the board. //Peter -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
