On 1/25/10 10:36 AM, Patrick Georgi wrote: > --- src/mainboard/Kconfig (revision 5050) > +++ src/mainboard/Kconfig (working copy) > @@ -287,6 +287,11 @@ > default "Roda" > depends on VENDOR_RODA > > +config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID > + hex > + default 0x4352 > + depends on VENDOR_RODA > + > config MAINBOARD_VENDOR > string > default "Soyo" > @@ -302,6 +307,11 @@ > default "Supermicro" > depends on VENDOR_SUPERMICRO > > +config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID > + hex > + default 0x15d9 > + depends on VENDOR_SUPERMICRO > + > config MAINBOARD_VENDOR > string > default "Technexion" Is there a reason this is in mainboard/Kconfig?
It seems this would better go to the mainboard's Kconfig files... (and for some mainboards, it does...) > Index: src/mainboard/supermicro/h8dmr_fam10/Kconfig > =================================================================== > --- src/mainboard/supermicro/h8dmr_fam10/Kconfig (revision 5050) > +++ src/mainboard/supermicro/h8dmr_fam10/Kconfig (working copy) > @@ -136,3 +136,8 @@ > bool > default n > depends on BOARD_SUPERMICRO_H8DMR_FAM10 > + > +config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID > + hex > + default 0x1511 > + depends on BOARD_SUPERMICRO_H8DMR_FAM10 I think we should stay consistent here. Otherwise: Acked-by: Stefan Reinauer <[email protected]> -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: [email protected] • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
