Am 25.01.2010 11:31, schrieb Stefan Reinauer: >> +config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID >> + hex >> + default 0x15d9 >> + depends on VENDOR_SUPERMICRO >> + >> config MAINBOARD_VENDOR >> string >> default "Technexion" >> > Is there a reason this is in mainboard/Kconfig? > VENDOR_ID appears for various vendors in that file. One could argue that VENDOR_IDs don't belong in mainboard Kconfig files (that was the intention behind moving them to src/mainboard/Kconfig, I guess), but then, we have msi/ms9185 (with AMD vendor id)
>> Index: src/mainboard/supermicro/h8dmr_fam10/Kconfig >> =================================================================== >> --- src/mainboard/supermicro/h8dmr_fam10/Kconfig (revision 5050) >> +++ src/mainboard/supermicro/h8dmr_fam10/Kconfig (working copy) >> @@ -136,3 +136,8 @@ >> bool >> default n >> depends on BOARD_SUPERMICRO_H8DMR_FAM10 >> + >> +config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID >> + hex >> + default 0x1511 >> + depends on BOARD_SUPERMICRO_H8DMR_FAM10 >> > I think we should stay consistent here. > This is the DEVICE_ID, those belong in the mainboard's Kconfig. Patrick -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
