Myles Watson escribió: > > > On Fri, Mar 12, 2010 at 4:00 AM, Knut Kujat <[email protected] > <mailto:[email protected]>> wrote: > > Hello, > > this patch fixes the issue where the board wasn't able to start after > getting unplugged. I also added some GPIOs so now the power on led is > working. > > > The spacing doesn't look like it follows these guidelines: > http://www.coreboot.org/Development_Guidelines#Coding_Style Sorry, Patrick tells me so, too! I'll take a look at that article this weekend. > > static inline void activate_spd_rom(const struct mem_controller *ctrl) > { > - /* nothing to do */ > +#define SMBUS_SWITCH1 0x70 > +#define SMBUS_SWITCH2 0x72 > +// unsigned device=(ctrl->spd_addr[0])>>8; > It's unclear what this comment is for. Maybe just drop it? Yes, that one can go, since I was testing multiple options because I wasn't really sure what to do. > > Signed-off-by: Knut Kujat <[email protected] <mailto:[email protected]>> > > With the formatting and comment addressed: > Acked-by: Myles Watson <[email protected] <mailto:[email protected]>> > > Thanks, > Myles
thx and have a nice weekend, Knut Kujat. -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
