On 3/18/10 3:42 AM, Peter Stuge wrote:
> repository service wrote:
>   
>>      printk_debug("biosint:  ip 0x%x   cs 0x%x  flags 0x%x\n",
>> -                 ip, cs, flags);
>> +                 (u32)ip, (u32)cs, (u32)flags);
>>     
> Aren't ip and cs just 16? flags is 32 though.
>   

They're all unsigned long in vsmsetup.c, so that's what theoretically
can be passed to the function. I think the right way would be to fix the
function. The even better way would be to use devices/oprom/x86.c instead.
Patches welcome


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [email protected]http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to