-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Rudolf Marek wrote: > I found that in k8 CAR set_var_mtrr is set as it the arguments would be an > adresses, but in fact they HAVE TO be in kilobytes.
Hi again, I re-checked and it was OK, we do have an early function with same name which takes bytes parameters (mtrr-early.c). So this is not the case. I investigated MTRRs bit more. The RAM init on AMD does not use the varmtrr0 and varmtrr1 the reason is that it thinks the first is used for 0-RAMBASE second for ROM caching. I also changed the XIP MTRR setup to cache whole ROM with the MTRR. I think it is OK to do it this way... After the code goes to the post_cache_as_ram.c it sets up an mtrr for the coreboot_ram as 0-RAMTOP. Maybe we can go with a big mtrr 0-TOM and create UCs for VGA.... Thanks, Rudolf -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkveAJ8ACgkQ3J9wPJqZRNVDnwCZAariG5FhnCoDs9Nx2H7JAJeq 1rAAnRMKFMYD+EwhlOfotaufe/s2kOIU =GILC -----END PGP SIGNATURE----- -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
