On Thu, Sep 9, 2010 at 1:39 PM, Myles Watson <[email protected]> wrote: >> There are now three smaller patches attached: > Much nicer! Thanks. > >> (1) Changes specific to this board. Fairly small changes from AMD >> Tilapia. Requires (2) to work. > > From your mainboard's Kconfig: > > +config DIMM_SUPPORT > + hex > + default 0x0004 > + depends on CPU_AMD_SOCKET_AM3 > > This really worries me. You shouldn't need to change the type of memory on > the Socket. I looked at your board online, and they suggest that your board > supports socket AM2, AM2+, and AM3. That seems like it breaks our model. I > thought AM2 was DDR2 and AM3 was DDR3.
That used to be true, but you can have AM3(AM2+) with DDR2, as with this board. Yeah, thanks AMD..... :) Connecting the socket to the memory type was convenient, but I was never really comfortable with it. It may be time to disconnect them. Marc -- http://se-eng.com -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
