Author: uwe Date: Sat Sep 25 16:58:28 2010 New Revision: 5843 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5843
Log: Various CONFIG_DEBUG_RAM_SETUP related fixes (trivial). Some boards still used the old DEBUG_RAM_SETUP (without _CONFIG prefix). Also, consistently use "#if CONFIG_DEBUG_RAM_SETUP" (not #ifdef) as we do elsewhere. Signed-off-by: Uwe Hermann <[email protected]> Acked-by: Uwe Hermann <[email protected]> Modified: trunk/src/mainboard/getac/p470/romstage.c trunk/src/mainboard/intel/d945gclf/romstage.c trunk/src/mainboard/roda/rk886ex/romstage.c trunk/src/northbridge/intel/i440lx/Kconfig trunk/src/northbridge/intel/i440lx/raminit.c trunk/src/northbridge/via/vt8601/Kconfig trunk/src/northbridge/via/vt8601/raminit.c Modified: trunk/src/mainboard/getac/p470/romstage.c ============================================================================== --- trunk/src/mainboard/getac/p470/romstage.c Sat Sep 25 16:23:31 2010 (r5842) +++ trunk/src/mainboard/getac/p470/romstage.c Sat Sep 25 16:58:28 2010 (r5843) @@ -379,7 +379,7 @@ #if CONFIG_HAVE_ACPI_RESUME == 0 /* When doing resume, we must not overwrite RAM */ -#if defined(DEBUG_RAM_SETUP) +#if CONFIG_DEBUG_RAM_SETUP sdram_dump_mchbar_registers(); { Modified: trunk/src/mainboard/intel/d945gclf/romstage.c ============================================================================== --- trunk/src/mainboard/intel/d945gclf/romstage.c Sat Sep 25 16:23:31 2010 (r5842) +++ trunk/src/mainboard/intel/d945gclf/romstage.c Sat Sep 25 16:58:28 2010 (r5843) @@ -295,7 +295,7 @@ #if !CONFIG_HAVE_ACPI_RESUME #if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8 -#if defined(DEBUG_RAM_SETUP) +#if CONFIG_DEBUG_RAM_SETUP sdram_dump_mchbar_registers(); #endif Modified: trunk/src/mainboard/roda/rk886ex/romstage.c ============================================================================== --- trunk/src/mainboard/roda/rk886ex/romstage.c Sat Sep 25 16:23:31 2010 (r5842) +++ trunk/src/mainboard/roda/rk886ex/romstage.c Sat Sep 25 16:58:28 2010 (r5843) @@ -355,7 +355,7 @@ #if !CONFIG_HAVE_ACPI_RESUME #if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8 -#if defined(DEBUG_RAM_SETUP) +#if CONFIG_DEBUG_RAM_SETUP sdram_dump_mchbar_registers(); { Modified: trunk/src/northbridge/intel/i440lx/Kconfig ============================================================================== --- trunk/src/northbridge/intel/i440lx/Kconfig Sat Sep 25 16:23:31 2010 (r5842) +++ trunk/src/northbridge/intel/i440lx/Kconfig Sat Sep 25 16:58:28 2010 (r5843) @@ -19,4 +19,5 @@ config NORTHBRIDGE_INTEL_I440LX bool + select HAVE_DEBUG_RAM_SETUP Modified: trunk/src/northbridge/intel/i440lx/raminit.c ============================================================================== --- trunk/src/northbridge/intel/i440lx/raminit.c Sat Sep 25 16:23:31 2010 (r5842) +++ trunk/src/northbridge/intel/i440lx/raminit.c Sat Sep 25 16:58:28 2010 (r5843) @@ -31,7 +31,7 @@ /* Uncomment this to enable debugging output. */ /* Debugging macros. */ -#if defined(DEBUG_RAM_SETUP) +#if CONFIG_DEBUG_RAM_SETUP #define PRINT_DEBUG(x) print_debug(x) #define PRINT_DEBUG_HEX8(x) print_debug_hex8(x) #define PRINT_DEBUG_HEX16(x) print_debug_hex16(x) @@ -215,7 +215,7 @@ reg32 &= 0xe8000000U; pci_write_config32(NB, APBASE, reg32); - #ifdef DEBUG_RAM_SETUP +#if CONFIG_DEBUG_RAM_SETUP /* * apbase dont get set still, no idea what i have doing wrong yet, * i am almost sure that somehow i set it by mistake once, but can't @@ -225,7 +225,7 @@ PRINT_DEBUG("APBASE "); PRINT_DEBUG_HEX32(reg32); PRINT_DEBUG("\n"); - #endif +#endif } @@ -265,7 +265,7 @@ * i am not sure if that is needed, but was usefull * for me to confirm what got written */ -#ifdef DEBUG_RAM_SETUP +#if CONFIG_DEBUG_RAM_SETUP PRINT_DEBUG(" Set register 0x"); PRINT_DEBUG_HEX8(register_values[i]); PRINT_DEBUG(" to 0x"); Modified: trunk/src/northbridge/via/vt8601/Kconfig ============================================================================== --- trunk/src/northbridge/via/vt8601/Kconfig Sat Sep 25 16:23:31 2010 (r5842) +++ trunk/src/northbridge/via/vt8601/Kconfig Sat Sep 25 16:58:28 2010 (r5843) @@ -1,3 +1,4 @@ config NORTHBRIDGE_VIA_VT8601 bool + select HAVE_DEBUG_RAM_SETUP Modified: trunk/src/northbridge/via/vt8601/raminit.c ============================================================================== --- trunk/src/northbridge/via/vt8601/raminit.c Sat Sep 25 16:23:31 2010 (r5842) +++ trunk/src/northbridge/via/vt8601/raminit.c Sat Sep 25 16:58:28 2010 (r5843) @@ -69,7 +69,7 @@ } } -#ifdef CONFIG_DEBUG_RAM_SETUP +#if CONFIG_DEBUG_RAM_SETUP static void dumpnorth(device_t north) { unsigned int r, c; -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
