Hey folks, I am looking for some comments on the following patch. It unifies the socket 940 cache-as-ram implementation. Previously, the affected boards had their own CAR options in their Kconfig files. There is a default set of CAR configs in the socket.
Does anyone have comments on why this patch should or should not be committed? I would like to commit this since it would unify the socket 940 CAR implementation. However, I feel like I cannot properly gauge the risk of this change to the affected boards, and I'd like some comments from more experienced developers. Thanks, wt 8<---------------------------------------------------------------------- The affected boards had special one-off configurations in the past. This patch unifies them by using the CAR configuration from the socket instead. Signed-off-by: Warren Turkal <[email protected]> --- src/mainboard/broadcom/blast/Kconfig | 12 ------------ src/mainboard/ibm/e325/Kconfig | 12 ------------ src/mainboard/ibm/e326/Kconfig | 12 ------------ src/mainboard/newisys/khepri/Kconfig | 8 -------- src/mainboard/sunw/ultra40/Kconfig | 8 -------- src/mainboard/tyan/s4880/Kconfig | 8 -------- src/mainboard/tyan/s4882/Kconfig | 8 -------- 7 files changed, 0 insertions(+), 68 deletions(-) diff --git a/src/mainboard/broadcom/blast/Kconfig b/src/mainboard/broadcom/blast/Kconfig index 943627a..563c5ff 100644 --- a/src/mainboard/broadcom/blast/Kconfig +++ b/src/mainboard/broadcom/blast/Kconfig @@ -21,18 +21,6 @@ config MAINBOARD_DIR string default broadcom/blast -config DCACHE_RAM_BASE - hex - default 0xcf000 - -config DCACHE_RAM_SIZE - hex - default 0x01000 - -config DCACHE_RAM_GLOBAL_VAR_SIZE - hex - default 0x0 - config APIC_ID_OFFSET hex default 0x0 diff --git a/src/mainboard/ibm/e325/Kconfig b/src/mainboard/ibm/e325/Kconfig index d986eb4..d02c66b 100644 --- a/src/mainboard/ibm/e325/Kconfig +++ b/src/mainboard/ibm/e325/Kconfig @@ -21,18 +21,6 @@ config MAINBOARD_DIR string default ibm/e325 -config DCACHE_RAM_BASE - hex - default 0xcf000 - -config DCACHE_RAM_SIZE - hex - default 0x1000 - -config DCACHE_RAM_GLOBAL_VAR_SIZE - hex - default 0x0 - config APIC_ID_OFFSET hex default 0x0 diff --git a/src/mainboard/ibm/e326/Kconfig b/src/mainboard/ibm/e326/Kconfig index 10c5181..c974029 100644 --- a/src/mainboard/ibm/e326/Kconfig +++ b/src/mainboard/ibm/e326/Kconfig @@ -21,18 +21,6 @@ config MAINBOARD_DIR string default ibm/e326 -config DCACHE_RAM_BASE - hex - default 0xcf000 - -config DCACHE_RAM_SIZE - hex - default 0x1000 - -config DCACHE_RAM_GLOBAL_VAR_SIZE - hex - default 0x0 - config APIC_ID_OFFSET hex default 0x0 diff --git a/src/mainboard/newisys/khepri/Kconfig b/src/mainboard/newisys/khepri/Kconfig index 3d7aade..64d3df8 100644 --- a/src/mainboard/newisys/khepri/Kconfig +++ b/src/mainboard/newisys/khepri/Kconfig @@ -20,14 +20,6 @@ config MAINBOARD_DIR string default newisys/khepri -config DCACHE_RAM_BASE - hex - default 0xcf000 - -config DCACHE_RAM_SIZE - hex - default 0x01000 - config APIC_ID_OFFSET hex default 0x0 diff --git a/src/mainboard/sunw/ultra40/Kconfig b/src/mainboard/sunw/ultra40/Kconfig index ac07513..853db4f 100644 --- a/src/mainboard/sunw/ultra40/Kconfig +++ b/src/mainboard/sunw/ultra40/Kconfig @@ -19,14 +19,6 @@ config MAINBOARD_DIR string default sunw/ultra40 -config DCACHE_RAM_BASE - hex - default 0xcf000 - -config DCACHE_RAM_SIZE - hex - default 0x01000 - config APIC_ID_OFFSET hex default 0x10 diff --git a/src/mainboard/tyan/s4880/Kconfig b/src/mainboard/tyan/s4880/Kconfig index c9c59b1..8d9de8b 100644 --- a/src/mainboard/tyan/s4880/Kconfig +++ b/src/mainboard/tyan/s4880/Kconfig @@ -20,14 +20,6 @@ config MAINBOARD_DIR string default tyan/s4880 -config DCACHE_RAM_BASE - hex - default 0xcf000 - -config DCACHE_RAM_SIZE - hex - default 0x01000 - config APIC_ID_OFFSET hex default 0x10 diff --git a/src/mainboard/tyan/s4882/Kconfig b/src/mainboard/tyan/s4882/Kconfig index f19448f..6ab362c 100644 --- a/src/mainboard/tyan/s4882/Kconfig +++ b/src/mainboard/tyan/s4882/Kconfig @@ -20,14 +20,6 @@ config MAINBOARD_DIR string default tyan/s4882 -config DCACHE_RAM_BASE - hex - default 0xcf000 - -config DCACHE_RAM_SIZE - hex - default 0x01000 - config APIC_ID_OFFSET hex default 0x10 -- 1.7.1 -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
