Notice that it is also changing the base of the CAR area and, in some cases, the size of the global variable region. Should I be worried about those?
Thanks, wt On Thu, Sep 30, 2010 at 2:58 PM, Myles Watson <[email protected]> wrote: >> I am looking for some comments on the following patch. It unifies the >> socket 940 cache-as-ram implementation. Previously, the affected boards >> had their own CAR options in their Kconfig files. There is a default set >> of CAR configs in the socket. >> >> Does anyone have comments on why this patch should or should not be >> committed? > > Pro: > It's simpler. > > Con: > It probably slows booting a little, since there's more stack to copy. I > have no idea how much. > > The code handles either CAR size already, so it shouldn't break anything. > > Thanks, > Myles > > > -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
