On Sat, Oct 02, 2010 at 12:09:31AM +0200, Stefan Reinauer wrote: > On 10/1/10 11:27 PM, Uwe Hermann wrote: > > See patch. > > > > abuilt-tested. > > > > > > Uwe. > IMHO the patch makes it really hard to actually see what the code does. > I think Idwer was recently running into a problem where the use of > post_code would trash %eax were hard to comprehend. Now we seem have a > lot more code that comes from somewhere else and touches registers > without it being obvious to the reader of the code. > > Just my 2ct.
Well, lets make it 4cts. I think the code is easier to read when it is all right there. The CAR code is doing something very complex - trying to abstract out a few minor operations I think could further obscure what is occurring. -Kevin -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
