On Sun, Oct 17, 2010 at 10:51:06PM -0700, Warren Turkal wrote:
> On Sunday, October 17, 2010 07:39:06 am Jonathan A. Kollasch wrote:
> > Provide for I/O space access on NetBSD.
> > 
> > Signed-off-by: Jonathan Kollasch <[email protected]>
> > ---
> 
> It might be better to use "inline" instead of "__inline" and define a macro 
> to 
> use the real name you want on certain platorms since c99 reserves the keyword 
> "inline" for this purpose.

Well, the Makefile gives the compiler -ansi ...

> Having said that, do those functions really need to be inlined?

Maybe, they aren't used that much, and may as well flow right into
the code IMO.

        Jonathan Kollasch

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to