On Mon, Oct 18, 2010 at 6:42 AM, Jonathan A. Kollasch <[email protected]> wrote: > On Sun, Oct 17, 2010 at 10:51:06PM -0700, Warren Turkal wrote: >> It might be better to use "inline" instead of "__inline" and define a macro >> to >> use the real name you want on certain platorms since c99 reserves the keyword >> "inline" for this purpose. > > Well, the Makefile gives the compiler -ansi ...
The Makefile can be changed. >> Having said that, do those functions really need to be inlined? > > Maybe, they aren't used that much, and may as well flow right into > the code IMO. Two counters: * GCC can inline functions that don't declare themselves inline, and it can refuse to inline one that use the __inline attribute. I think it'd be better to rely on compiler optimizations than to explicitly state that it's inline. * Superiotool isn't some long running process, so an optimization that makes the code less readable is not really useful. I believe that it makes the code less readable by embedding functional code (i.e. not just prototypes and macros) in a header file.' Thanks, wt -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
