On 18.10.2010, at 12:17, Peter Stuge <[email protected]> wrote: > Jonathan A. Kollasch wrote: >> Remove unused variables from 6300ESB smbus_write_block(). >> >> #if 0 smbus_write_byte() and smbus_write_block() as they are >> static and nothing uses them or are incompletely implemented. > > Why #if 0 rather than just removing the code completely? I think this > is a piece of code which can already be found other places if a > reference is needed?
Maybe use #ifdef DEADCODE if you want to leave it in. That will make it easier to recognize that the code was considered for dropping once before. > >> Signed-off-by: Jonathan Kollasch <[email protected]> > > Acked-by: Peter Stuge <[email protected]> > > -- > coreboot mailing list: [email protected] > http://www.coreboot.org/mailman/listinfo/coreboot > -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
