On Sat, Nov 06, 2010 at 01:56:45PM +0100, Patrick Georgi wrote: > Hi, > > I moved the SET_FIDVID family of configuration options to Kconfig, > adapting its use (CONFIG_ prefix), and tried to minimize the board > specific settings. > > They get some defaults in src/cpu/amd/model_*xx/Kconfig, which are > derived from the various #ifndef ... #define ... #endif blocks I removed > in the cpu specific code. > > All "#define SET_FIDVID 0" in romstage.c files weren't necessary due to > these defaults, as well as all "#define SET_FIDVID 1" in Fam10 boards, > so these were stripped. > Some "select SET_FIDVID" could probably still be removed. >
So far so good. I'm not sure FIDVID can be an option for fam10 . BKDG require it but I don't know if any fam10 cpu can boot without it. > SET_FIDVID_CORE0_ONLY was always 1, so again, I moved this to the CPU. > It isn't always 1. It's 0 for FAM10. But the patch is right as far as I can see asleep as I am. -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
