On Tue, Jan 25, 2011 at 8:16 AM, Joseph Kellermann <[email protected]> wrote: > This patch fixes a potential system hang (see 'Revision Guide for AMD NPT > Family 0Fh Processors' 33610.pdf). > > Signed-off-by: Josef Kellermann <[email protected]> >
Hi Josef, Thanks for the patch. I have some questions. It looks like this patch mixed errata #131, #169, with #254. The rev guide says to only implement #131 or #169, but there isn't a CPU version decadency on either of those errata. The main part of your patch, the S1G1 checking, looks like errata #254, which is not related to #169 or #131. Can you confirm that? Marc -- http://se-eng.com -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
